-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Brian 2.6 #314
Update for Brian 2.6 #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @mstimberg ! Looks good to me. I like the catch_logs
updates, I struggled a bit to get it working with brian2cuda and it needed occasional test updates, so glad this seems to be fixed. But does the bug you referenced mean that tests are currently failing and will pass for the next Brian2 release? If so, should we add that as expected to fail to the test suite?
I didn't follow the run_args
implementation in detail, but I'm assuming its mostly copy-paste since its running all in host code, right?
And are you running the test suite locally with GPU access? Or should I do that (I would have to set things up first since our cluster infrastructure has changed and I haven't used it since).
Approving. Feel free to merge if tests have run.
Hi. So there are several things related to logs that have been fixed (or were supposed to) :
Points 1 and 2 work fine, point 3 is unfortunately broken in 2.6.0. (but already fixed in
Yes, it's ugly, but it is exactly the same ugliness as in C++ standalone ;)
I've been running the tests on my laptop with a GPU – not fast, but good enough for now. |
A bit of a silly issue, but 2.6.0 may render 0 and 1 as false and true, breaking a check in the rng code. See brian-team/brian2#1520
I forgot to fix a test (for a silly thing, see brian-team/brian2#1520), but now all tests pass on my machine 👍 This also means it is time to do a new release! If I am not mistaken, this simply means creating a new tag ( |
This PR should move Brian2CUDA to compatibility with Brian 2.6, in particular with its useful new
run_args
feature.Two remarks:
run_args
feature is an ugly mix of compile-time and run-time code, hopefully we can refactor this nicely in the future (it shouldn't have to be duplicated between Brian2 and Brian2CUDA in the first place).brian2
, but it erroneously included all package names starting withbrian2
, sobrian2cuda
log messages were still counted...